[b4.4] Fix value increment in test_sampler #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test sampler access raw metric value with `mval->v_u64` and increment that value by 1. This works for integer values. When `mval` contains float or double, `mval->v_u64` became big number due to IEEE 754 binary32 or binary64 format. As such, `test_sampler` should use `ldms_mval_as_u64()` to coerce the `mval` to u64 properly.
This was referenced Nov 5, 2024
narategithub
changed the title
added 2 commits
November 7, 2024 21:02
The value update should use `ldms_mval_as_u64()` to correctly coerce the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test sampler access raw metric value with
mval->v_u64and increment that value by 1. This works for integer values. Whenmvalcontains float or double,mval->v_u64became big number due to IEEE 754 binary32 or binary64 format. As such,test_samplershould useldms_mval_as_u64()to coerce themvalto u64 properly.