Decomp func op #1400
Decomp func op #1400
Conversation
These changes allow for the application of functional operators in the generation of column data in decomposed rows.
|
I think the containers need libjansson >=2.11 to support json_error_code(). |
|
Yes. libjansson 2.13.1 was installed from source in the CentOS-based
images (ovishpc/ovis-centos-build and ovishpc/ovis-compat-centos7).
…On Fri, May 31 2024 at 11:07:18 AM -0700, Christopher J. Morrone ***@***.***> wrote:
I think the containers need libjansson >=2.11 to support
json_error_code().
—
Reply to this email directly, view it on GitHub
<#1400 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADT3O7A2VLZHRLTHQNB53YTZFC35NAVCNFSM6AAAAABISBOWYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBSG42DMMJYGA>.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
I believe this should pass all the workflow once @tom95858 trigger the re-run of the workflows. |
|
Should we get rid of the code that relies on the later version? What can we
reasonably expect to be installed?
On Fri, May 31, 2024, 12:26 PM Narate Taerat ***@***.***>
wrote:
… Yes. libjansson 2.13.1 was installed from source in the CentOS-based
images (ovishpc/ovis-centos-build and ovishpc/ovis-compat-centos7).
On Fri, May 31 2024 at 11:07:18 AM -0700, Christopher J. Morrone
***@***.***> wrote:
> I think the containers need libjansson >=2.11 to support
> json_error_code().
>
> —
> Reply to this email directly, view it on GitHub
> <#1400 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ADT3O7A2VLZHRLTHQNB53YTZFC35NAVCNFSM6AAAAABISBOWYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBSG42DMMJYGA>.
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#1400 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVTPXHO2JOUNHT5PENS5HTZFC6DZAVCNFSM6AAAAABISBOWYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBSG43TONBSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@tom95858 I noticed that you have |
|
@narategithub I think the conditional you added is fine. For the CentOS7 images, then yeah, you should install the libjansson-devel version to whatever is shipped with the distro. |
The libjansson parser has better documentation and better error reporting. The API is easier to use resulting in less code required for JSON parsing. The __decomp decorator in front of most plugin symbols has also been removed as this is unnecessary for static symbols and variables.
|
@tom95858 the images were updated accordingly with libjansson that shipped with the distro. FYI, I tried the commit without the JANSSON_VERSION_HEX conditional here: narategithub#27 (in my repo) and it failed as expected (undefined The commit with JANSSON_VERSION_HEX condition passed the workflows: narategithub#28 (with libjansson that shipped with the distro). |
This set of changes implements functional operators in the decomposition path. These changes also change the JSON parser to use the libjansson library which provides better error reporting and an easier to use API.