Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlink stream format harmonization for 4.4 #1392

Merged
merged 2 commits into from
May 20, 2024

Conversation

baallan
Copy link
Collaborator

@baallan baallan commented Apr 22, 2024

Adds format 3 option to the netlink publisher. This makes linux/slurm/lsf json messages and init/exit messages similar in field ordering to the maximum extent possible so that creating policies and tools transforming stream data across resource managers is simpler.

baallan added 2 commits April 19, 2024 12:43
…ers.

Sorts the differences among formats to the end of the messages.
message format specific store plugins will remain compatible if they
get data by name rather than json position.
@baallan baallan requested a review from bschwal April 22, 2024 19:54
@baallan baallan changed the title Netlink stream format harmonization Netlink stream format harmonization for 4.4 Apr 23, 2024
Copy link
Collaborator

@bschwal bschwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and will be extremely helpful for better pid collection. Testing on hpc cluster over several days showed we captured all jobs ran on the system .

@tom95858 tom95858 merged commit aabe405 into ovis-hpc:b4.4 May 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants