Fix buffer size declaration in syspapi #1366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfm_name copy may be up to size of .info field being copied.
|
@baallan need to cherry pick this to ovis-4 |
tom95858
reviewed
Mar 2, 2024
| @@ -89,7 +89,7 @@ typedef struct syspapi_metric_s { | |||
| int init_rc; /* if 0, attr is good for perf_event_open() */ | |||
| struct perf_event_attr attr; /* perf attribute */ | |||
| char papi_name[256]; /* metric name in PAPI */ | |||
| char pfm_name[256]; /* metric name in perfmon (PAPI native) */ | |||
| char pfm_name[PAPI_HUGE_STR_LEN]; /* metric name in perfmon (PAPI native) */ | |||
There was a problem hiding this comment.
@baallan, I don't believe that this field is used anywhere. We should just remove it instead of consuming 1k for every papi metric.
There was a problem hiding this comment.
@tom95858 it is copied at line 251 into a buffer which is just 256 bytes while the papi source string is up to 1024. The alternative is to make the structure's pfm_name field separately allocated and freed, which would be a much bigger change.
There was a problem hiding this comment.
@baallan, after it is copied in there it is never used again. My suggestion is to just remove the field instead of wasting 1k for every event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pfm_name copy may be up to size of .info field being copied.
this uses the papi header macro to match.