Make ldms_xprt_listen_by_name() prefers IPv6.
#1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ldms_xprt_listen_by_name()` listened to 0.0.0.0 IPv4 address by default if `host` is `NULL`. This patch made `ldms_xprt_listen_by_name()` to fully rely on `getaddrinfo()` in resolving the addresses, and then we pick the first IPv6 address. If no IPv6 addresses available, the first address returned by `getaddrinfo()` is used. This has been tested with `ldmsd` on IPv4-only machine, and IPv4+6 machine. On IPv4+6 machine, if the users only to listen on IPv4 addresses, they have to either provide listening address on the CLI (e.g. `-x sock:411:0.0.0.0`), or specify the host in config file (e.g. `listen port=411 xprt=sock host=0.0.0.0`).
|
This is a patch to address #1311 . |
|
NOTE: Compatibility test failed due to ldms_ls-4.3.3 to ldmsd-4 (top-of-tree) having an issue with munge authentication. This is because ldmsd-4 sent back IPv6 munge payload, but ldms_ls-4.3.3 expects IPv4 in the payload. I'm looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ldms_xprt_listen_by_name()listened to 0.0.0.0 IPv4 address by default ifhostisNULL. This patch madeldms_xprt_listen_by_name()to fully rely ongetaddrinfo()in resolving the addresses, and then we pick the first IPv6 address. If no IPv6 addresses available, the first address returned bygetaddrinfo()is used.This has been tested with
ldmsdon IPv4-only machine, and IPv4+6 machine.On IPv4+6 machine, if the users only to listen on IPv4 addresses, they have to either provide listening address on the CLI (e.g.
-x sock:411:0.0.0.0), or specify the host in config file (e.g.listen port=411 xprt=sock host=0.0.0.0).