Fix LDMS/LDMSD passive/bridge support #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldms_xprt_event_cb_set() allows applications to set the event callback handler. This is useful especially for the passive endpoints, which LDMS automatically sets the event_cb pointer to the same function pointer passed to ldms_xprt_listen(). LDMSD uses this function in the PASSIVE producer path.
The rail patch did not refactor ldms_xprt_by_remote_sin() to return the rail handle to application. The patch corrects this.
Without the patch, ldms_xprt_rail_new() always creates the initial ldms_xprt endpoint. However, it is unnecessary when handling a connection request. This also results in that ldms_xprt leaks endpoints when the peer disconnects. The patch also fixes the dangling endpoint problem.
nichamon
changed the title
|
The patch has been tested against ovis-hpc/ldms-test#60. I also manually tested the disconnection scenario. |
The patch fixes the passive code path in LDMS and LDMSD, and add the bridge_add, bridge_del, bridge_start, bridge_stop commands in ldmsd_controller and configuration files. The commands are a wrapper of the corresponding producer config commands. Under the hood, LDMSD treats bridges as another producer type. It does not have the bridge config objects.
nichamon
force-pushed
the
fix-passive-mode
branch
from
1110113 to
78f5d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.