Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return test_slps to installcheck-local with time,zap io limits #1145

Closed
wants to merge 2 commits into from

Conversation

baallan
Copy link
Collaborator

@baallan baallan commented Mar 21, 2023

this checks the return code and wraps test_slps in 'timeout' so it cannot hang forever, should a transport hang occur.
also
fixes #1095

@tom95858
Copy link
Collaborator

tom95858 commented May 7, 2023

@nichamon, did you get a chance to review this?

Copy link
Collaborator

@nichamon nichamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that the line that sets the returned code had been removed. I saw the "no-kokkos blocking ok" messages in the build-test-ubuntu workflow. I didn't confirm that the "no-kokkos blocking test timed out" messages will be reported if the test_slps script gets timeout.

@tom95858
Copy link
Collaborator

@baallan can you resolve the conflicts in this pull request?

@baallan
Copy link
Collaborator Author

baallan commented Nov 22, 2023

I rebased to top of tree; checking into what's causing the distcheck fails.

@baallan
Copy link
Collaborator Author

baallan commented Nov 28, 2023

test_slps is failing in the transport layer in something rails related.
Nothing new in this patch is at fault, but if it is merged, then installcheck will be failing, possibly due to test code which has not caught up with recent rails api changes.
I've ported this patch to the 441rc2 branch as a separate pr #1300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simple_lps.c resets ldmsd_stream_publish()'s returned code variable and then checks the value
3 participants