Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator decomposition row cache cleanup improvements #1553

Open
morrone opened this issue Dec 11, 2024 · 0 comments
Open

Operator decomposition row cache cleanup improvements #1553

morrone opened this issue Dec 11, 2024 · 0 comments

Comments

@morrone
Copy link
Collaborator

morrone commented Dec 11, 2024

In issue #1483, and the associated PRs, a timeout was introduced to clean up stale row caches from operators in decomposition.

Really, what would be better is to cleanup the row cache dynamically when either:

  • An individual group associated with a metric set goes away, or
  • A metric set goes away, triggering cleanup of all related row caches

The rationale is that some metric sets may remain live, but not updated when there are no updates to the data in the metric set. As long as the metric set remains live, we would like to retain the row cache. With only a timeout method, the timeouts need to be carefully coordinated by a human to get them right.

If we cleared the caches dynamically, no humans need to spend time figuring things out to make the cleanup work correctly (or just giving up and picking a very long timeout). Dynamic cache cleanup would just do the Right Thing without human intervention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant