Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace long array syntax with short syntax #138

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

peter279k
Copy link
Contributor

Changed log

  • It should be good to use the short array syntax to replace the long array syntax.

Signed-off-by: peter279k <peter279k@gmail.com>
@rbeuque74
Copy link
Member

Hello @peter279k ,

Does this modification improve stuff in the PHP engine, or fix a deprecation of the array() keyword that we wouldn't be aware of ?

Thanks
Romain

@peter279k
Copy link
Contributor Author

The feature is about improving stuff. Thanks.

@rbeuque74
Copy link
Member

Hello @peter279k

Can you be a bit more specific?

We are willing to accept contributions that we understand what is the real added value to our project.

Thanks
Romain

@peter279k
Copy link
Contributor Author

peter279k commented Oct 13, 2023

There're some reasons about the PR:

  • It can make it readable.
  • It can be consistency with the array syntax. All of codes use the shorten array syntax except for this line of code.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #138 (d453da6) into master (d4840af) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #138   +/-   ##
=========================================
  Coverage     97.52%   97.52%           
  Complexity       36       36           
=========================================
  Files             1        1           
  Lines           121      121           
=========================================
  Hits            118      118           
  Misses            3        3           
Files Coverage Δ
src/Api.php 97.52% <100.00%> (ø)

@rbeuque74 rbeuque74 merged commit d2c2161 into ovh:master Oct 13, 2023
13 checks passed
@peter279k peter279k deleted the short_array branch October 19, 2023 08:19
deathiop pushed a commit to deathiop/php-ovh that referenced this pull request Oct 20, 2023
Replace long array syntax with short syntax

Signed-off-by: Adrien Barreau <adrien.barreau@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants