feat(mrc): add disable more info prop to onboarding #16383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipp972
force-pushed
the
fix/16382-onboarding-more-info-disabled
branch
from
4574619 to
ba9b717
Compare
1 task
chipp972
changed the title
chipp972
changed the title
|
qpavy
previously approved these changes
Apr 10, 2025
anooparveti
reviewed
Apr 10, 2025
packages/manager-react-components/src/components/templates/onboarding/onboarding.component.tsx
Outdated
Show resolved
Hide resolved
anooparveti
reviewed
Apr 10, 2025
packages/manager-react-components/src/components/templates/onboarding/onboarding.component.tsx
Outdated
Show resolved
Hide resolved
anooparveti
reviewed
Apr 10, 2025
packages/manager-react-components/src/components/templates/onboarding/onboarding.component.tsx
Outdated
Show resolved
Hide resolved
anooparveti
reviewed
Apr 10, 2025
packages/manager-react-components/src/components/templates/onboarding/onboarding.component.tsx
Outdated
Show resolved
Hide resolved
anooparveti
reviewed
Apr 10, 2025
packages/manager-react-components/src/components/templates/onboarding/onboarding.component.tsx
Outdated
Show resolved
Hide resolved
chipp972
force-pushed
the
fix/16382-onboarding-more-info-disabled
branch
from
ba9b717 to
ff8e097
Compare
mhelhali-soufien
previously approved these changes
Apr 11, 2025
anooparveti
reviewed
Apr 14, 2025
| moreInfoHref?: string; | ||
| moreInfoButtonIcon?: ODS_ICON_NAME; | ||
| moreInfoButtonLabel?: string; | ||
| onmoreInfoButtonClick?: () => void; |
There was a problem hiding this comment.
Suggested change
| onmoreInfoButtonClick?: () => void; | |
| onMoreInfoButtonClick?: () => void; |
anooparveti
reviewed
Apr 14, 2025
| moreInfoHref, | ||
| moreInfoButtonLabel, | ||
| moreInfoButtonIcon = ODS_ICON_NAME.externalLink, | ||
| onmoreInfoButtonClick, |
There was a problem hiding this comment.
Suggested change
| onmoreInfoButtonClick, | |
| onMoreInfoButtonClick, |
anooparveti
reviewed
Apr 14, 2025
| if (moreInfoHref) { | ||
| window.open(moreInfoHref, '_blank'); | ||
| if (!isMoreInfoButtonDisabled) { | ||
| onmoreInfoButtonClick?.(); |
There was a problem hiding this comment.
Suggested change
| onmoreInfoButtonClick?.(); | |
| onMoreInfoButtonClick?.(); |
ref: #ISSUE-16382 Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
chipp972
force-pushed
the
fix/16382-onboarding-more-info-disabled
branch
from
ff8e097 to
3cd5678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket Reference: #...
Additional Information