Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): optimize pnr performance by removing services count logic #15351

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

aottr
Copy link
Contributor

@aottr aottr commented Feb 6, 2025

ref: MANAGER-15637

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15637
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Switch from Array.reduce to Array.some since we don't display the actual services count anymore and instead highlight if the customer has a service from a specific offering or not.

Related

@aottr aottr requested a review from a team February 6, 2025 14:45
@aottr aottr requested a review from a team as a code owner February 6, 2025 14:45
@github-actions github-actions bot added container feature New feature labels Feb 6, 2025
@aottr aottr force-pushed the feat/MANAGER-15637 branch from ab89aa1 to 0b4c4da Compare February 6, 2025 14:54
ref: MANAGER-15637

Signed-off-by: Dustin Kroger <dustin.kroger.ext@ovhcloud.com>
@aottr aottr force-pushed the feat/MANAGER-15637 branch from 0b4c4da to fc4387e Compare February 6, 2025 15:25
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@aottr aottr changed the title feat(container): optimize pnr performance by removing services count feat(container): optimize pnr performance by removing services count logic Feb 6, 2025
@JacquesLarique JacquesLarique changed the base branch from develop to release/gcj-w8 February 13, 2025 16:10
@JacquesLarique JacquesLarique merged commit a387959 into release/gcj-w8 Feb 13, 2025
17 of 18 checks passed
@JacquesLarique JacquesLarique deleted the feat/MANAGER-15637 branch February 13, 2025 16:28
@JacquesLarique JacquesLarique mentioned this pull request Feb 14, 2025
3 tasks
JacquesLarique pushed a commit that referenced this pull request Feb 18, 2025
…15351)

ref: MANAGER-15637

Signed-off-by: Dustin Kroger <dustin.kroger.ext@ovhcloud.com>
aottr added a commit that referenced this pull request Feb 20, 2025
…15351)

ref: MANAGER-15637

Signed-off-by: Dustin Kroger <dustin.kroger.ext@ovhcloud.com>
ppprevost pushed a commit that referenced this pull request Feb 20, 2025
…15351)

ref: MANAGER-15637

Signed-off-by: Dustin Kroger <dustin.kroger.ext@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants