Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated): add datacenter network tab #15252

Merged
merged 1 commit into from
Feb 7, 2025
Merged

feat(dedicated): add datacenter network tab #15252

merged 1 commit into from
Feb 7, 2025

Conversation

pauldkn
Copy link
Contributor

@pauldkn pauldkn commented Feb 3, 2025

Question Answer
Branch? feat/custom-nsx-edges-sizing-bis
Bug fix? no
New feature? yes
Breaking change? no
Tickets feat/MANAGER-16613
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@pauldkn pauldkn requested review from fredericvilcot, frenautvh and a team as code owners February 3, 2025 08:36
@pauldkn pauldkn requested review from qpavy, JacquesLarique, seven-amid and MaximeBajeux and removed request for a team February 3, 2025 08:36
@pauldkn pauldkn changed the base branch from feat/custom-nsx-edges-sizing-bis to master February 3, 2025 08:44
@pauldkn pauldkn force-pushed the feat/MANAGER-16613 branch from eb7cd2e to 3a39302 Compare February 3, 2025 18:09
@github-actions github-actions bot removed continuous-integration Changes to our CI configuration files and scripts universe-web-cloud labels Feb 3, 2025
@pauldkn pauldkn force-pushed the feat/MANAGER-16613 branch from 3a39302 to 70c474d Compare February 5, 2025 09:06
@darsene darsene marked this pull request as draft February 5, 2025 11:21
@pauldkn pauldkn force-pushed the feat/MANAGER-16613 branch 3 times, most recently from b101cfe to 7071fa9 Compare February 5, 2025 16:53
@pauldkn pauldkn marked this pull request as ready for review February 5, 2025 16:54
darsene
darsene requested changes Feb 6, 2025
View reviewed changes
...ps/dedicated/client/app/components/dedicated-cloud/datacenter/dedicatedCloud-datacenter.html Outdated Show resolved Hide resolved
.../app/components/dedicated-cloud/datacenter/host/dedicatedCloud-datacenter-host.controller.js Outdated Show resolved Hide resolved
...ed/client/app/components/dedicated-cloud/datacenter/host/dedicatedCloud-datacenter-host.html Outdated Show resolved Hide resolved
...ges/manager/apps/dedicated/client/app/components/dedicated-cloud/datacenter/network/index.js Outdated Show resolved Hide resolved
...oud/datacenter/network/onboarding/dedicatedCloud-datacenter-network-onboarding.controller.js Outdated Show resolved Hide resolved
...edCloud/datacenter/network/onboarding/dedicatedCloud-datacenter-network-onboarding.module.js Outdated Show resolved Hide resolved
...edCloud/datacenter/network/onboarding/dedicatedCloud-datacenter-network-onboarding.module.js Outdated Show resolved Hide resolved
...dCloud/datacenter/network/onboarding/dedicatedCloud-datacenter-network-onboarding.routing.js Show resolved Hide resolved
...ages/manager/apps/dedicated/client/app/dedicatedCloud/datacenter/network/onboarding/index.js Show resolved Hide resolved
...apps/dedicated/client/app/dedicatedCloud/datacenter/network/translations/Messages_fr_FR.json Show resolved Hide resolved
@darsene
Copy link
Contributor

darsene commented Feb 6, 2025

@pauldkn can you target the feature branch instead of master

@pauldkn pauldkn force-pushed the feat/MANAGER-16613 branch from 7071fa9 to 856eb42 Compare February 6, 2025 17:31
feat(dedicated): add datacenter network tab
1ff64ac 
ref: MANAGER-16613

Signed-off-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
@pauldkn pauldkn changed the base branch from master to feat/custom-nsx-edges-sizing-bis February 7, 2025 09:22
@pauldkn pauldkn force-pushed the feat/MANAGER-16613 branch from 856eb42 to 1ff64ac Compare February 7, 2025 09:22
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
27.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@pauldkn pauldkn merged commit e1816e8 into feat/custom-nsx-edges-sizing-bis Feb 7, 2025
13 of 14 checks passed
@pauldkn pauldkn deleted the feat/MANAGER-16613 branch February 7, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibs245 tibs245 tibs245 approved these changes

@darsene darsene darsene approved these changes

@fredericvilcot fredericvilcot Awaiting requested review from fredericvilcot

@frenautvh frenautvh Awaiting requested review from frenautvh

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-reactjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-reactjs

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required universe-bare-metal-cloud universe-hosted-private-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauldkn @darsene @tibs245