Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup! feat(sap-features-hub): add pre-installation form step5 #15200

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fixup! feat(sap-features-hub): add pre-installation form step5 #15200

merged 1 commit into from
Jan 30, 2025

Conversation

pauldkn
Copy link
Contributor

@pauldkn pauldkn commented Jan 30, 2025

Question Answer
Branch? feat/sap-features-hub
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

fixup! feat(sap-features-hub): add pre-installation form step5
75abc74 
Signed-off-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
@pauldkn pauldkn requested a review from a team January 30, 2025 12:17
@pauldkn pauldkn requested a review from a team as a code owner January 30, 2025 12:17
@pauldkn pauldkn requested review from MaximeBajeux, chipp972, sidlynx and seven-amid and removed request for a team January 30, 2025 12:17
@github-actions github-actions bot added the feature New feature label Jan 30, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pauldkn pauldkn merged commit df6b993 into feat/sap-features-hub Jan 30, 2025
14 checks passed
@pauldkn pauldkn deleted the feat/sap-remove-sid-placeholder branch January 30, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibs245 tibs245 tibs245 approved these changes

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux

@chipp972 chipp972 Awaiting requested review from chipp972

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldkn @tibs245