fix(web.hosting): change 2api call by iceberg on domain configuration #15185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (subDomain !== '' ? ['www', subDomain].join('.') : 'www') | ||
| ); | ||
| } | ||
| return record.subDomain === subDomain; |
There was a problem hiding this comment.
Suggested change
| return record.subDomain === subDomain; | |
| return record.subDomain === subDomain || (wwwNeeded && record.subDomain === ['www', subDomain].filter(Boolean).join('.')) ; |
It might do the same thing not sure if it's more readable tho
tristanwagner
previously approved these changes
Jan 30, 2025
stif59100
previously approved these changes
Jan 30, 2025
ghyenne
force-pushed
the
fix/MANAGER-16782
branch
from
66342f3 to
7c0184b
Compare
ref: MANAGER-16782 Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
ghyenne
force-pushed
the
fix/MANAGER-16782
branch
from
7c0184b to
1a0e9d0
Compare
|
tristanwagner
approved these changes
Jan 30, 2025
stif59100
approved these changes
Jan 30, 2025
ghyenne
changed the base branch from
master
to
release/hosting-collaboration-w7
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
I changed 2api call by iceberg on domain configuration
Related