Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): implement changelog button on angular stack #15174

Merged
merged 8 commits into from
Feb 12, 2025
Merged

feat(*): implement changelog button on angular stack #15174

merged 8 commits into from
Feb 12, 2025

Conversation

MaximeBajeux
Copy link
Contributor

ref:

Question Answer
Branch? feat/MANAGER-16546-angular
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-16546
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Implementation of the changelog button on angular stack

Related

@MaximeBajeux MaximeBajeux requested review from a team, qpavy, anooparveti and JacquesLarique and removed request for a team January 29, 2025 09:37
@MaximeBajeux MaximeBajeux changed the title feat(*): implement changelog button on bare metal feat(*): implement changelog button on angular stack Feb 3, 2025
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-impl-angular branch from 2b7d8d8 to f9c308d Compare February 5, 2025 13:28
SimonChaumet
SimonChaumet approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@SimonChaumet SimonChaumet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could have been factorized between different apps, especially in pci where it imports the constant and it's the same markup for every app

@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-angular branch from 21bd202 to a9890c0 Compare February 6, 2025 17:16
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-impl-angular branch 2 times, most recently from f5f5ac0 to c17e56b Compare February 7, 2025 16:42
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-angular branch from 686b248 to bf5b83f Compare February 7, 2025 17:48
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Feb 7, 2025
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-impl-angular branch from c17e56b to 6ead910 Compare February 10, 2025 13:21
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Feb 10, 2025
@JacquesLarique JacquesLarique force-pushed the feat/MANAGER-16546-angular branch from 5079afd to 6147e52 Compare February 11, 2025 15:04
@JacquesLarique JacquesLarique requested a review from a team February 11, 2025 15:04
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Feb 11, 2025
@JacquesLarique JacquesLarique force-pushed the feat/MANAGER-16546-angular branch from 6147e52 to 007e104 Compare February 11, 2025 15:06
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-impl-angular branch from 6ead910 to ede4502 Compare February 12, 2025 09:39
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed has conflicts Has conflicts to resolve before merging labels Feb 12, 2025
Base automatically changed from feat/MANAGER-16546-angular to release/changelog-button-component February 12, 2025 09:46
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Feb 12, 2025
@MaximeBajeux
feat(*): implement changelog button on bare metal
9c2b50a 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
@MaximeBajeux
feat(*): add changelog button on hpc and network universes
c615fb9 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
@MaximeBajeux
feat(web): implement changelog button
2bd479d 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
@MaximeBajeux
feat(telecom): add changelog button
957fccf 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
@MaximeBajeux
fix(dedicated): fix changelog with bad variable
83aafea 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
@MaximeBajeux
feat(pci): implement changelog button into pci angular
ad0a8d4 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
@MaximeBajeux
fix(dedicated): fix injection error on baremetal
8e5c0c8 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
@MaximeBajeux
fix(dedicated): fix injection error on servers
1ba4857 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-impl-angular branch from ede4502 to 1ba4857 Compare February 12, 2025 09:54
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Feb 12, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
48 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Feb 12, 2025
@MaximeBajeux MaximeBajeux merged commit fc12e13 into release/changelog-button-component Feb 12, 2025
15 checks passed
@MaximeBajeux MaximeBajeux deleted the feat/MANAGER-16546-impl-angular branch February 12, 2025 15:17
MaximeBajeux added a commit that referenced this pull request Feb 18, 2025
@MaximeBajeux
feat(*): implement changelog button on angular stack (#15174)
1637e59 
ref: MANAGER-16546
Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
MaximeBajeux added a commit that referenced this pull request Feb 20, 2025
@MaximeBajeux
feat(*): implement changelog button on angular stack (#15174)
e5a3678 
ref: MANAGER-16546
Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
MaximeBajeux added a commit that referenced this pull request Feb 20, 2025
@MaximeBajeux
feat(*): implement changelog button on angular stack (#15174)
a965c89 
ref: MANAGER-16546
Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
ppprevost pushed a commit that referenced this pull request Feb 20, 2025
@MaximeBajeux
feat(*): implement changelog button on angular stack (#15174)
f1de158 
ref: MANAGER-16546
Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
JacquesLarique pushed a commit that referenced this pull request Mar 7, 2025
@MaximeBajeux
feat(*): implement changelog button on angular stack (#15174)
328daf5 
ref: MANAGER-16546
Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonChaumet SimonChaumet SimonChaumet approved these changes

@qpavy qpavy Awaiting requested review from qpavy

@anooparveti anooparveti Awaiting requested review from anooparveti

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique

Assignees
No one assigned
Labels
common feature New feature universe-bare-metal-cloud universe-hosted-private-cloud universe-public-cloud universe-telecom universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximeBajeux @SimonChaumet