Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(veeam): replace offer price translation #14920

Merged
merged 2 commits into from
Jan 31, 2025
Merged

feat(veeam): replace offer price translation #14920

merged 2 commits into from
Jan 31, 2025

Conversation

ThibaudCrespin
Copy link
Contributor

@ThibaudCrespin ThibaudCrespin commented Jan 15, 2025 •
edited by darsene
Loading

ref: MANAGER-16340

Question Answer
Branch? develop
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #MANAGER-16340
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

🎏 Translation

  • CMT-20766

vovh
vovh previously approved these changes Jan 15, 2025
View reviewed changes
tibs245
tibs245 previously approved these changes Jan 15, 2025
View reviewed changes
@antleblanc antleblanc dismissed stale reviews from tibs245 and vovh via 0a64abe January 30, 2025 10:44
@darsene darsene changed the base branch from develop to release/hpc-enabler-w6 January 30, 2025 16:28
Thibaud Crespin added 2 commits January 30, 2025 17:38
@darsene
feat(veeam): replace offer price translation
42dc7c7 
ref: MANAGER-16340

Signed-off-by: Thibaud Crespin <thibaud.crespin.ext@ovhcloud.com>
@darsene
fix(i18n): add missing translations [CDS 3673]
7e86795 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@darsene darsene force-pushed the feat/MANAGER-16340 branch from 0a64abe to 7e86795 Compare January 30, 2025 16:38
@darsene darsene mentioned this pull request Jan 30, 2025
Merged
4 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@darsene darsene merged commit e927387 into release/hpc-enabler-w6 Jan 31, 2025
13 of 15 checks passed
@darsene darsene deleted the feat/MANAGER-16340 branch January 31, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldkn pauldkn pauldkn approved these changes

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@tibs245 tibs245 tibs245 left review comments

@vovh vovh vovh left review comments

@oalkabouss oalkabouss Awaiting requested review from oalkabouss

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique

Assignees
No one assigned
Labels
feature New feature translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ThibaudCrespin @tibs245 @pauldkn @vovh @rjamet-ovh @darsene