Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zimbra): change content and add guides on onboarding #14821

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix(zimbra): change content and add guides on onboarding #14821

merged 2 commits into from
Feb 4, 2025

Conversation

ghyenne
Copy link
Contributor

@ghyenne ghyenne commented Jan 8, 2025

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets MANAGER-14642
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

I changed content and add guides on onboarding

Related

@ghyenne ghyenne requested a review from a team January 8, 2025 11:10
@ghyenne ghyenne requested a review from a team as a code owner January 8, 2025 11:10
stif59100
stif59100 previously approved these changes Jan 9, 2025
View reviewed changes
JacquesLarique
JacquesLarique reviewed Jan 9, 2025
View reviewed changes
packages/manager/apps/zimbra/public/translations/onboarding/Messages_fr_FR.json Outdated
"card_guide_title_1": "Premiers pas avec l'offre Zimbra",
"card_guide_title_2": "Configurer son compte Zimbra",
"card_guide_title_3": "Maitriser le webmail Zimbra",
"card_guide_description_1": "Découvrez comment créer vos premieres boites mail et administrer votre service",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"card_guide_description_1": "Découvrez comment créer vos premieres boites mail et administrer votre service",
"card_guide_description_1": "Découvrez comment créer vos premières boites mail et administrer votre service",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed.

tibs245
tibs245 previously approved these changes Jan 9, 2025
View reviewed changes
@ghyenne ghyenne dismissed stale reviews from tibs245 and stif59100 via 501fa94 January 10, 2025 07:25
stif59100
stif59100 previously approved these changes Jan 10, 2025
View reviewed changes
@ghyenne ghyenne force-pushed the fix/MANAGER-14642 branch 2 times, most recently from ef16134 to efd768c Compare January 16, 2025 09:02
tristanwagner
tristanwagner previously approved these changes Jan 16, 2025
View reviewed changes
stif59100
stif59100 previously approved these changes Jan 17, 2025
View reviewed changes
@ghyenne ghyenne dismissed stale reviews from stif59100 and tristanwagner via c4ddd02 January 27, 2025 16:37
tristanwagner
tristanwagner previously approved these changes Jan 27, 2025
View reviewed changes
tristanwagner
tristanwagner previously approved these changes Jan 27, 2025
View reviewed changes
stif59100
stif59100 previously approved these changes Jan 27, 2025
View reviewed changes
tristanwagner
tristanwagner reviewed Jan 29, 2025
View reviewed changes
packages/manager/apps/zimbra/src/pages/onboarding/index.tsx Outdated
img={{ src: onboardingImgSrc }}
description={description}
description={t('description')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to pass an OdsText instead of a string now to match the required design because of some changes that happened in OnboardingLayout

@ghyenne
fix(zimbra): change content and add guides on onboarding
1ffbfad 
ref: MANAGER-14642

Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
@ghyenne ghyenne dismissed stale reviews from stif59100 and tristanwagner via 1ffbfad January 30, 2025 09:50
@ghyenne ghyenne changed the base branch from master to release/zimbra-ga February 4, 2025 11:02
@ghyenne @ovh-cds
fix(i18n): add missing translations [CDS 210]
bce0df0 
Signed-off-by: CDS Translator Agent <opensource@ovh.net>
@ghyenne ghyenne merged commit 44b163b into release/zimbra-ga Feb 4, 2025
9 of 12 checks passed
@ghyenne ghyenne deleted the fix/MANAGER-14642 branch February 4, 2025 11:14
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ghyenne ghyenne mentioned this pull request Feb 4, 2025
Merged
3 tasks
@github-actions github-actions bot added the fix label Feb 4, 2025
ghyenne added a commit that referenced this pull request Feb 5, 2025
@ghyenne @ovh-cds
fix(zimbra): change content and add guides on onboarding (#14821)
74604fe 
ref: MANAGER-14642

Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
selm3n pushed a commit that referenced this pull request Feb 6, 2025
@ghyenne @ovh-cds
fix(zimbra): change content and add guides on onboarding (#14821)
952b177 
ref: MANAGER-14642

Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Steffy29 pushed a commit that referenced this pull request Feb 7, 2025
@ghyenne @ovh-cds
fix(zimbra): change content and add guides on onboarding (#14821)
9f81737 
ref: MANAGER-14642

Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
lionel95200x pushed a commit that referenced this pull request Feb 12, 2025
@ghyenne @ovh-cds
fix(zimbra): change content and add guides on onboarding (#14821)
070168f 
ref: MANAGER-14642

Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
ppprevost pushed a commit that referenced this pull request Feb 12, 2025
@ghyenne @ovh-cds
fix(zimbra): change content and add guides on onboarding (#14821)
c9c6fc5 
ref: MANAGER-14642

Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
ppprevost pushed a commit that referenced this pull request Feb 17, 2025
@ghyenne @ovh-cds
fix(zimbra): change content and add guides on onboarding (#14821)
71a1eec 
ref: MANAGER-14642

Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
aottr pushed a commit that referenced this pull request Feb 20, 2025
@ghyenne @ovh-cds @aottr
fix(zimbra): change content and add guides on onboarding (#14821)
08b399c 
ref: MANAGER-14642

Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
ppprevost pushed a commit that referenced this pull request Feb 20, 2025
@ghyenne @ovh-cds
fix(zimbra): change content and add guides on onboarding (#14821)
53efec3 
ref: MANAGER-14642

Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
Co-authored-by: CDS Translator Agent <opensource@ovh.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique left review comments

@tristanwagner tristanwagner tristanwagner approved these changes

@stif59100 stif59100 stif59100 approved these changes

@tibs245 tibs245 tibs245 left review comments

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud Awaiting requested review from aboungnaseng-ovhcloud

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@aottr aottr Awaiting requested review from aottr

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn

Assignees
No one assigned
Labels
bug Something isn't working fix translation required universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ghyenne @tibs245 @tristanwagner @stif59100 @JacquesLarique