Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/dtcore 2668 #13660

Merged
merged 10 commits into from
Oct 21, 2024
Merged

Feat/dtcore 2668 #13660

merged 10 commits into from
Oct 21, 2024

Conversation

sidlynx
Copy link
Contributor

@sidlynx sidlynx commented Oct 18, 2024

Question Answer
Branch? feat/pci-load-balancer
Bug fix? no
New feature? yes
Breaking change? no
Tickets DTCORE-2666 & DTCORE-2668
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@sidlynx sidlynx requested review from a team as code owners October 18, 2024 07:01
@sidlynx sidlynx requested review from frenautvh, seven-amid, anooparveti, darsene and mhelhali-soufien and removed request for a team October 18, 2024 07:01
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 18, 2024
@sidlynx
feat(pci-load-balancer): sizeinput for create page
70e2cd6 
ref: DTCORE-2666

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(pci-load-balancer): create page first step
87181e0 
ref: DTCORE-2668

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(pci-load-balancer): create page second step
4809584 
ref: DTCORE-2668

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(pci-load-balancer): create page third step
8523470 
ref: DTCORE-2668

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(pci-load-balancer): create page fourth step
243dcc4 
ref: DTCORE-2668

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(pci-load-balancer): create page fifth step
3f34f02 
ref: DTCORE-2668

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(pci-load-balancer): create page last step
4730556 
ref: DTCORE-2668

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@github-actions github-actions bot added translation required dependencies Pull requests that update a dependency file feature New feature and removed has conflicts Has conflicts to resolve before merging labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
uuid UPDATED 9.0.1 10.0.0

@sidlynx
feat(pci-load-balancer): refacto
4194ab0 
ref: DTCORE-2668

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(pci-load-balancer): tracking
1316cf3 
ref: DTCORE-2668

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sidlynx
feat(manager-react-components): add skip to stepcomponent
1c2ef45 
ref: DTCORE-2668

Signed-off-by: Mohammed Hamdoune <sidlynx@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@sidlynx sidlynx self-assigned this Oct 21, 2024
frenautvh
frenautvh reviewed Oct 21, 2024
View reviewed changes
packages/manager/apps/pci-load-balancer/src/api/hook/useLoadBalancer.tsx
}),
onError,
onSuccess: async () => {
// TDOO invalidate right query
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it be done in another PR ?

Copy link
Contributor Author

@sidlynx sidlynx Oct 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep i forgot to invalidate the query, fortunately i left the TODO there, will fix it in the TUs task

@sidlynx sidlynx merged commit 0b5dbd4 into feat/pci-load-balancer Oct 21, 2024
12 of 14 checks passed
@sidlynx sidlynx deleted the feat/DTCORE-2668 branch October 21, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqesar kqesar kqesar approved these changes

@frenautvh frenautvh frenautvh approved these changes

@seven-amid seven-amid seven-amid approved these changes

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@sidlynx sidlynx

Labels
dependencies Pull requests that update a dependency file feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sidlynx @kqesar @frenautvh @seven-amid