Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another ffm stack bump #128

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/block_ffm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ use crate::regressor;
use crate::quantization;
use crate::regressor::{BlockCache, FFM_CONTRA_BUF_LEN};

const FFM_STACK_BUF_LEN: usize = 170393;
const FFM_STACK_BUF_LEN: usize = 320000;
const STEP: usize = 4;
const ZEROES: [f32; STEP] = [0.0; STEP];

Expand Down Expand Up @@ -300,7 +300,7 @@ impl<L: OptimizerTrait + 'static> BlockTrait for BlockFFM<L> {
core_macro!(local_data_ffm_values);
} else {
// Slow-path - using heap data structures
log::warn!("FFM data too large, allocating on the heap (slow path)!");
log::warn!("FFM data too large, allocating on the heap (slow path)! Allowed: {}, observed: {}", FFM_STACK_BUF_LEN, local_data_ffm_len);
let _guard = self.mutex.lock().unwrap(); // following operations are not thread safe
if local_data_ffm_len > self.local_data_ffm_values.len() {
self.local_data_ffm_values
Expand Down
Loading