Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate for a Nextflow-based MVP #528

Draft
wants to merge 64 commits into
base: master
Choose a base branch
from
Draft

Conversation

GallVp
Copy link
Collaborator

@GallVp GallVp commented Dec 18, 2024

PR checklist

  • PR to nextflow_reboot branch
  • conda and container directives.
  • Docker container + singularity container (optional)
  • Flow meta.id with each data channel
  • Use nf-core resource labels such as process_high
  • Used nf-core module
  • Use versions.yml or versions topic
  • No process in the main.nf. We can have a process in a sub-workflow file

GallVp and others added 30 commits November 26, 2024 21:35
Added fasta_helitronscanner_scan_draw sub workflow
@GallVp GallVp marked this pull request as draft December 18, 2024 04:45
@GallVp GallVp requested review from jguhlin and oushujun December 18, 2024 04:45
@GallVp
Copy link
Collaborator Author

GallVp commented Dec 18, 2024

Hello @oushujun , @jguhlin

This PR includes an MVP the Nextflow-based implementation of EDTA. Currently, only two parameters are supported,

  1. --genome, which can be a single Fasta or a text file listing Fastas
  2. --species

I'll continue working on other parameters. But I think we need to meet in the next year and go through a couple of things,

  1. Development and release workflow
  2. Contribution guidelines
  3. Validation
  4. Documentation

@GallVp
Copy link
Collaborator Author

GallVp commented Dec 18, 2024

The test failures are related to singularity permissions issue. This might be because the PR is coming from outside this repo or because of some other repo setting. We can look at it in a meeting.

@oushujun
Copy link
Owner

OK, thank you for the great work! Let me know when you want to meet.

Shujun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants