Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change strict equality for active screens to use functions for readability #1057

Open
2 tasks done
NabbeunNabi opened this issue Feb 20, 2025 · 0 comments
Open
2 tasks done
Assignees
Labels
code quality enhancement New feature or request

Comments

@NabbeunNabi
Copy link
Contributor

Problem

We are using strict comparability often for what screen is active throughout the moderation panel. For example
v-else-if="moderationScreenStore.activeScreen === ModerationScreen.EditSubmission" in the ModTopbar.vue.

Success

The equalities are refactored into functions that make it readable. For example dashboardScreenIsActive()

Requirements

  • Add functions for each active screen in the moderationScreenStore.ts
  • Update where this is being used around the mod panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants