Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate formatting to Eslint Stylistic #434

Merged
merged 1 commit into from
May 24, 2024
Merged

Migrate formatting to Eslint Stylistic #434

merged 1 commit into from
May 24, 2024

Conversation

Anissa3005
Copy link
Contributor

@Anissa3005 Anissa3005 commented Jan 30, 2024 •
edited
Loading

Resolves #353

What changed

  • I have added the ESLint stylistic plugin to be able to keep using our formatting rules in ESLint config file.
  • I have change the formatting rules that will be deprecated. The links below lists all the rules that will be effected.

These changes triggered formatting in a few files, so there are quite few files that have formatting changes in them. Please check if these changes are valid.

These are all the rules that are covered by ESLint Stylistic: https://eslint.style/packages/default
ESLint Deprecation of Formatting rules: https://eslint.org/blog/2023/10/deprecating-formatting-rules/

Testing instructions

NA

@socket-security Socket Security
Copy link

socket-security bot commented Jan 30, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@stylistic/eslint-plugin-migrate@1.5.4 Transitive: environment, eval, filesystem, shell, unsafe +123 45.8 MB antfu
npm/@stylistic/eslint-plugin@1.5.4 Transitive: environment, eval, filesystem, shell, unsafe +119 44.3 MB antfu

View full report↗︎

@Anissa3005 Anissa3005 changed the title chore: migrate to Eslint Stylistic Migrate formatting to Eslint Stylistic Jan 31, 2024
@Anissa3005 Anissa3005 force-pushed the anissa/migration-eslint branch from 9546482 to b10f3cc Compare January 31, 2024 06:10
Anissa3005
Anissa3005 commented Jan 31, 2024
View reviewed changes
Anissa3005
Anissa3005 commented Jan 31, 2024
View reviewed changes
ermish
ermish reviewed Jan 31, 2024
View reviewed changes
@Anissa3005 Anissa3005 marked this pull request as ready for review January 31, 2024 07:15
@Anissa3005 Anissa3005 marked this pull request as draft January 31, 2024 07:18
@Anissa3005 Anissa3005 marked this pull request as ready for review January 31, 2024 07:40
@Anissa3005
chore: migrate to Eslint Stylistic
adafaee 
Eslint has desided to deprecated their formatting rules. So for
formatting we will use a plugin, Eslint Stylistic to be able to use the
formatting rules.
@Anissa3005 Anissa3005 force-pushed the anissa/migration-eslint branch from 02fd60a to adafaee Compare January 31, 2024 07:42
@Anissa3005 Anissa3005 requested a review from ermish January 31, 2024 07:45
@Anissa3005 Anissa3005 self-assigned this Jan 31, 2024
ermish
ermish approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@ermish ermish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice work.
I see some dangling commas still, but no reason to block

@ermish
Copy link
Collaborator

ermish commented May 14, 2024

merge when you're ready @Anissa3005

@theyokohamalife theyokohamalife merged commit 77fa6ca into main May 24, 2024
4 checks passed
@theyokohamalife theyokohamalife deleted the anissa/migration-eslint branch May 24, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermish ermish ermish approved these changes

Assignees

@Anissa3005 Anissa3005

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate eslint rules to use @stylistic
3 participants
@Anissa3005 @ermish @theyokohamalife