Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TCP port 53 when creating an allow all NetworkPolicy to kube-dns - to support TCP DNS #536

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

omris94
Copy link
Contributor

@omris94 omris94 commented Dec 15, 2024

Description

Up until this PR if the kubernetes DNS server was mentioned in a clientIntents resource as a target, we added to its network policy an "allow all UDP port 53 rule", in this PR we added an "allow all TCP port 53" rule so it will auto allow TCP DNS.

Testing

changed existing tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@omris94 omris94 requested a review from amitlicht December 15, 2024 17:04
@omris94 omris94 changed the title Allow TCP port 53 when creating an allow NetworkPolicy to kube-dns - to support TCP DNS Allow TCP port 53 when creating an allow all NetworkPolicy to kube-dns - to support TCP DNS Dec 15, 2024
@omris94 omris94 enabled auto-merge (squash) December 15, 2024 17:05
@omris94 omris94 merged commit 74bf78e into main Dec 15, 2024
19 checks passed
@omris94 omris94 deleted the omris/open-dns-for-tcp branch December 15, 2024 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants