Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: solve "Invalid signature" error on AWS IAM Roles Anywhere #519

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

amitlicht
Copy link
Contributor

Description

This fixes a bug in AWS IAM Roles Anywhere, caused due to a regression in AWS API.
Prior to this fix, an empty X-Amz-X509-Chain header was added to AWS Roles Anywhere CreateSession request. This recently started failing the request, due to a change in the AWS API.
This happens when the slice of intermediate CAs is empty. However, by passing a nil slice into the AWS roles anywhere signing helper, we make it avoid adding the empty header, which solves the issue.

References

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@amitlicht amitlicht requested a review from omris94 November 27, 2024 08:08
@amitlicht amitlicht marked this pull request as ready for review November 27, 2024 08:36
@amitlicht amitlicht merged commit 95f6fa0 into main Nov 27, 2024
22 checks passed
@amitlicht amitlicht deleted the amitlicht/rolesanywhere_bugfix branch November 27, 2024 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants