Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new Otterize-API endpoints for workload user and password management #96

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

omris94
Copy link
Contributor

@omris94 omris94 commented Nov 30, 2023

Description

Changing the graphql queries that create user and password for Kubernetes workloads following cloud changes.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • StackOverflow post
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@omris94 omris94 requested review from orishoshan and amitlicht and removed request for orishoshan November 30, 2023 21:37
Copy link
Contributor

@amitlicht amitlicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subject to comments on the cloud PR

src/operator/controllers/otterizeclient/client.go Outdated Show resolved Hide resolved
@omris94 omris94 requested a review from amitlicht December 4, 2023 13:44
@omris94 omris94 merged commit 96fc0bb into main Dec 5, 2023
4 checks passed
@omris94 omris94 deleted the omris/use-new-user-and-password-api branch December 5, 2023 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants