Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem where AWS IAM pod webhook could deny admission, fix problem where credentials operator would not report status to cloud despite being configured #95

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Fix problem where AWS IAM pod webhook could deny admission, fix problem where credentials operator would not report status to cloud despite being configured #95

merged 3 commits into from
Nov 27, 2023

Conversation

orishoshan
Copy link
Contributor

Description

This PR fixes two problems:

  • Fix problem where AWS IAM pod webhook handling errors could deny admission, if the ServiceAccount for the pod was not yet created.
    This was fixed by handling this specific case, but also make the webhook controller never deny admission, instead allow admission but submit a warning.
  • Fix problem where credentials operator would not report status to cloud despite being configured.

@orishoshan orishoshan requested a review from omris94 November 27, 2023 14:37
@orishoshan orishoshan merged commit 0f81b7a into main Nov 27, 2023
4 checks passed
@orishoshan orishoshan deleted the orisho/credentials_improvements branch November 27, 2023 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@omris94 omris94 omris94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orishoshan @omris94