Add AWS pod webhook that makes sure service accounts are annotated prior to pod being created #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, Otterize would create annotate ServiceAccounts with AWS role ARNs only after a Pod was created. This meant that the AWS pod identity webhook controller could not apply the environment variables before pod start, meaning a pod restart was required.
This pod webhook annotates service accounts prior to pod creation, although it leaves the actual AWS role management to a ServiceAccount reconciler, in order to run as fast as possible and with as little option for failure.
This webhook controller relies on the AWS webhook controller having configured reinvocation policy = IfNeeded, so that it's retriggered if the Otterize webhook runs first.
References
otterize/helm-charts#133
otterize/intents-operator#294