Fix bug: Sending nil when no namespaced pod owners found #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitlicht
approved these changes
Nov 12, 2023
NetanelBollag
requested review from
amitlicht
and removed request for
omris94
NetanelBollag
deleted the
netanelb/fix-bug/sending-nil-namespaced-pod-owners
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the operator doesn't find pod owners for
ReportActiveCertificateRequestersit sends a nil value. This PR initialize the slice to non-nil value and also skip the API call since the backend has nothing to do if the list is empty.