Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding call to error unwrap so we could compare with k8s errors #167

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

evyatarmeged
Copy link
Contributor

Please see the contributing guidelines for how to create and submit a high-quality PR for this repo. This template is based on Auth0's excellent template.

Description

Adding call to error unwrap so we could compare with k8s errors. Beforehand we would compare with a wrapped error which would never "hit" the Kubernetes IsError() functions

@evyatarmeged evyatarmeged assigned omris94 and unassigned omris94 Oct 13, 2024
@evyatarmeged evyatarmeged requested a review from omris94 October 13, 2024 16:23
@evyatarmeged evyatarmeged enabled auto-merge (squash) October 13, 2024 16:25
@evyatarmeged evyatarmeged merged commit ba6a6a6 into main Oct 13, 2024
5 checks passed
@evyatarmeged evyatarmeged deleted the evya/fix_wrapping_errors branch October 13, 2024 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants