Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database enforcement in OSS - credentials generation, secret creation & user creation in database #121

Merged
merged 20 commits into from
Apr 14, 2024
Merged

Database enforcement in OSS - credentials generation, secret creation & user creation in database #121

merged 20 commits into from
Apr 14, 2024

Conversation

evyatarmeged
Copy link
Contributor

@evyatarmeged evyatarmeged commented Mar 18, 2024 •
edited
Loading

Description

Added credentials-related support to compliment the move of database enforcement to our operators.

  • Secrets are generated by the credentials operator (as it always was), but it also generates the credentials now upon request.
  • It is now also responsible for validation & creation of users with said credentials in the database instances themselves. This provides the groundwork for the intents operator to configure database permissions based on client intents.

@evyatarmeged evyatarmeged requested a review from amitlicht March 18, 2024 18:23
@evyatarmeged evyatarmeged requested a review from amitlicht April 4, 2024 11:53
amitlicht
amitlicht requested changes Apr 7, 2024
View reviewed changes
src/operator/controllers/intents/reconciler.go Outdated Show resolved Hide resolved
src/operator/controllers/intents/reconciler.go Outdated Show resolved Hide resolved
src/operator/controllers/intents/reconciler.go Outdated Show resolved Hide resolved
@evyatarmeged evyatarmeged requested a review from amitlicht April 8, 2024 18:51
amitlicht
amitlicht approved these changes Apr 9, 2024
View reviewed changes
src/operator/controllers/intents/reconciler.go Outdated Show resolved Hide resolved
src/operator/controllers/intents/reconciler.go Outdated Show resolved Hide resolved
src/operator/controllers/intents/reconciler.go Outdated Show resolved Hide resolved
@evyatarmeged evyatarmeged force-pushed the evya/database_enforcement_poc_creds branch from 39ad633 to 4a7affa Compare April 13, 2024 14:16
@evyatarmeged evyatarmeged merged commit 9224f14 into main Apr 14, 2024
4 checks passed
@evyatarmeged evyatarmeged deleted the evya/database_enforcement_poc_creds branch April 14, 2024 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amitlicht amitlicht amitlicht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evyatarmeged @amitlicht