Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 (ci): Upgrade actions/cache, upload-artifacts to v4 #328

Closed
wants to merge 1 commit into from

Conversation

ladislas
Copy link
Member

No description provided.

@ladislas ladislas self-assigned this Mar 10, 2024
Copy link
Contributor

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The brew tap-new template still specifies actions/cache and actions/upload-artifact @ v3 (latter changed from main) - we should probably keep that as is:
https://github.com/Homebrew/brew/blob/master/Library/Homebrew/dev-cmd/tap-new.rb#L99

Homebrew/brew#16347

@ladislas
Copy link
Member Author

Okay I've got the answer to my question here. I'll merge your other PR then. Sorry for the back and forth.

@fauxpark
Copy link
Contributor

All good. This is a particularly annoying chicken-and-egg problem, isn't it? 😄

@ladislas
Copy link
Member Author

closing, already done in #325

@ladislas ladislas closed this Mar 11, 2024
@ladislas ladislas deleted the ladislas/feature/ci-upgrade-actions branch March 11, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants