Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused install deps scripts; clarify rules in CONTRIBUTING.md #35

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

NikitaZotov
Copy link
Member

@NikitaZotov NikitaZotov commented Jan 31, 2025


Important

Remove unused dependency scripts and update CONTRIBUTING.md and workflow cache keys for clarity.

  • Scripts:
    • Remove install_deps_macOS.sh and install_deps_ubuntu.sh from scripts/.
  • Workflows:
    • Update cache key in check_style.yml, release.yml, and test_conan.yml to remove dependency on install_deps_ubuntu.sh.
  • Documentation:
    • Clarify instructions in CONTRIBUTING.md regarding forking, rebasing, and commit message format.
    • Emphasize atomic commits and proper commit message tagging.

This description was created by Ellipsis for a2cf6d1. It will automatically update as commits are pushed.

@NikitaZotov NikitaZotov self-assigned this Jan 31, 2025
@NikitaZotov NikitaZotov added 0.1.0 documentation Improvements or additions to documentation labels Jan 31, 2025
@NikitaZotov NikitaZotov added this to the 0.1.0 milestone Jan 31, 2025
@NikitaZotov NikitaZotov added the enhancement New feature or request label Jan 31, 2025
Copy link
Member

@kilativ-dotcom kilativ-dotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to work on creating better pr headers
the one you've used is very unclear

@NikitaZotov NikitaZotov changed the title Hotfixes 0.1.0 Remove unused install deps scripts; clarify rules in CONTRIBUTING.md Jan 31, 2025
@NikitaZotov
Copy link
Member Author

NikitaZotov commented Jan 31, 2025

@ellipsis: Review this PR, please

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a2cf6d1 in 14 seconds

More details
  • Looked at 194 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. .github/workflows/check_style.yml:61
  • Draft comment:
    Removing hashFiles('**/install_deps_ubuntu.sh') from the cache key might reduce its uniqueness, potentially leading to cache collisions. Consider adding another unique identifier if necessary.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes the use of hashFiles('**/install_deps_ubuntu.sh') in the cache key, but the file is deleted in this PR, so this change is consistent. However, the cache key might become less unique, which could lead to cache collisions if other jobs use the same key format. It's important to ensure that the cache key remains unique enough to avoid such issues.
2. .github/workflows/release.yml:47
  • Draft comment:
    Removing hashFiles('**/install_deps_ubuntu.sh') from the cache key might reduce its uniqueness, potentially leading to cache collisions. Consider adding another unique identifier if necessary.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The same issue with cache key uniqueness applies here as well. Removing the hash of install_deps_ubuntu.sh might lead to cache collisions if the key is not unique enough.
3. .github/workflows/test_conan.yml:43
  • Draft comment:
    Removing hashFiles('**/install_deps_ubuntu.sh') from the cache key might reduce its uniqueness, potentially leading to cache collisions. Consider adding another unique identifier if necessary.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The same cache key uniqueness issue applies here as well. Removing the hash of install_deps_ubuntu.sh might lead to cache collisions if the key is not unique enough.

Workflow ID: wflow_KwVxxaZBrWf3vOpg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NikitaZotov NikitaZotov merged commit d831191 into ostis-ai:main Jan 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.1.0 documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants