Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baseline.yaml - NEW - OSPS-DO-15 #118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SecurityCRob
Copy link
Contributor

added new criteria proposal OSPS-DO-15 - around dependency selection process for projects

added new criteria proposal OSPS-DO-15 - around dependency selection process for projects

Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
baseline.yaml Outdated Show resolved Hide resolved
Comment on lines +656 to +658
The project documentation MUST include a
descriptive statement about how the project
selects, obtains, and tracks its dependencies.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pivot this from "project documentation describes" to something with more teeth? e.g.

- id: OSPS-QA-08
  category: Quality
  criteria: |
    The project has implemented automated review of
    changes to enforce a project-selected dependency
    policy.

It's not clear from this criteria whether something that says "if you add a package, remember to update package.json, we don't check in package-lock.json" could meet the maturity_level: 2 standard. (I'd hope not, but it is a descriptive statement about how the projects obtains and tracks its dependencies...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These might be two separate things. You can't check against a policy that you don't have, so maybe having any policy is level 1 and your suggestion is level 2?

@evankanderson
Copy link

Additionally, having a dependency-quality-check as automation would tie in well with OSPS-QA-04 around requiring status checks to pass.

@SecurityCRob SecurityCRob added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 18, 2024
fixed indent?

Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants