Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baseline.yaml - NEW - OSPS-DO-13 #115

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

SecurityCRob
Copy link
Contributor

new proposed criteria around support statements

new proposed criteria around support statements

Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
baseline.yaml Outdated Show resolved Hide resolved
baseline.yaml Outdated Show resolved Hide resolved
baseline.yaml Outdated Show resolved Hide resolved
baseline.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty good overall, but there are a few changes I'd like to see before merging.

baseline.yaml Outdated Show resolved Hide resolved
baseline.yaml Outdated Show resolved Hide resolved
baseline.yaml Outdated Show resolved Hide resolved
SecurityCRob and others added 4 commits December 17, 2024 16:45
Co-authored-by: Puerco <puerco@users.noreply.github.com>
Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
Co-authored-by: Eddie Knight <knight@linux.com>
Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
to address feedback, will split out "EoS" statements into separate criteria

Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a couple of nice-to-have comments.

baseline.yaml Outdated Show resolved Hide resolved
baseline.yaml Outdated Show resolved Hide resolved
SecurityCRob and others added 2 commits December 18, 2024 12:48
Co-authored-by: Ben Cotton <bcotton@funnelfiasco.com>
Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
Comment on lines +656 to +658
The project documentation MUST include a
descriptive statement about the scope and
duration of support.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some projects, the scope of support is tied (for example) to specific versions. E.g. Knative has:

https://github.com/knative/community/blob/main/mechanics/RELEASE-SCHEDULE.md#upcoming-releases

Releases supported by community

Release Date EOL Min K8s Version Notes
1.16 2024-10-22 2025-04-22 1.29
1.15 2024-07-23 2025-01-21 1.28

No longer supported releases

Release Date EOL Min K8s Version Notes
1.14 2024-04-23 2024-10-22 1.28

Having a standard mechanism of communicating this would be great, but it seems like there's a gap here between "having a descriptive statement" and "users can find the descriptive statement".

I realize this is a level 1 expectation, but I'd really like to be able to verify these statements. Is the idea to use security insights here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't see a standardized way to report EOL for a particular release branch, which seems like it's what people often actually need (I'm on 3.14 -- do I need to upgrade to 4.x, or will I get a 3.14.1?)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this looks like it is in #117 .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, support/lifecycle has always been challenging to ID. Each project handles it slightly differently. There are a few electronic means I'm aware of (Like OASIS's EoX) that could be explored, but there certainly is no STANDARD for this atm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, security insights could be a means to find this info

@SecurityCRob SecurityCRob added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants