Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build container image for arm64 #614

Open
blockmar opened this issue Dec 17, 2024 · 4 comments
Open

Build container image for arm64 #614

blockmar opened this issue Dec 17, 2024 · 4 comments

Comments

@blockmar
Copy link
Contributor

Today the release workflow seems to only build the container image for amd64.

It looks like ko support building multi-architecture images https://ko.build/features/multi-platform/

We use AWS arm graviton servers and would like to be able to run Allstar locally without having to rebuild the image for the arm64 platform.

@jeffmendoza
Copy link
Member

Hello, yes we'd be happy to build and publish those images as well. If you'd like to submit a PR I'll review and merge, otherwise I'll find some time over the winter break to add this.

@blockmar
Copy link
Contributor Author

blockmar commented Dec 18, 2024

Thank you for a quick response.

I'm familiar with the ko build command but checked documentation and tried manually triggering the updated release workflow in my fork. I could successfully pull and run arm images.

Created a PR: #615

@jeffmendoza
Copy link
Member

Thanks for that PR! I merged and tried a release. Looks like the arm image built and published correctly, but then our cosign step failed as the ref files have multiple lines. We probably just need a bash for loop on that file.

https://github.com/ossf/allstar/actions/runs/12402656909/job/34624614005

@blockmar
Copy link
Contributor Author

I've added my go of a fix. Feel free not to use it if you have a nicer solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants