Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove margined and milkyway from banner #61

Closed
wants to merge 1 commit into from
Closed

remove margined and milkyway from banner #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 1 addition & 35 deletions cms/swap-rotating-banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,6 @@
{
"$schema": "../schemas/swap-rotating-banner.schema.json",
"banners": [
{
"name": "milkTIA",
"startDate": "2023-12-18T14:30:00.123Z",
"endDate": "2024-01-25T14:30:00.123Z",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly we can make use of the endDate to hide this--in case might want to re-add this later. Or perhaps you prefer that it be removed completely when we aren't using it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, let's use the end date feature then

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot edit this PR, so if you aren't going to edit--I can make my own PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So MilkTIA ad is already hidden, so endDate does work, and for Margined I've set it to end yesterday, so it should hide.
I've made my own PR: #66

"headerOrTranslationKey": "milkHeader",
"subheaderOrTranslationKey": "milkSubheader",
"externalUrl": "/pool/1335",
"iconImageUrl": "https://raw.githubusercontent.com/osmosis-labs/fe-content/main/images/milkTIA.svg",
"iconImageAltOrTranslationKey": "milkImageAlt",
"gradient": "linear-gradient(93.62deg, #F7D1F2 -6.6%, #4B99FC 46.78%, #D3AAFB 105.39%)",
"fontColor": "#213469",
"arrowColor": "#213469",
"featured": true
},
{
"name": "Place limit orders",
"startDate": "2023-06-22T14:30:00.123Z",
Expand Down Expand Up @@ -42,20 +28,6 @@
"fontColor": "#FFF5C7",
"arrowColor": "#EED75F",
"featured": true
},
{
"name": "Margined Protocol",
"startDate": "2023-11-10T14:30:00.123Z",
"endDate": "2024-11-10T14:30:00.123Z",
"headerOrTranslationKey": "marginedHeader",
"subheaderOrTranslationKey": "marginedSubheader",
"externalUrl": "https://trade.margined.io/",
"iconImageUrl": "https://raw.githubusercontent.com/osmosis-labs/fe-content/main/images/feeling-bullish.svg",
"iconImageAltOrTranslationKey": "Chart increasing exponentially to the upper right over a background of dots",
"gradient": "linear-gradient(136deg, #020200 0%, #000000 47.66%, #373E24 100%)",
"fontColor": "#CBFD50",
"arrowColor": "#CBFD50",
"featured": true
}
],
"localization": {
Expand All @@ -74,18 +46,12 @@
"marginedImageAlt": "Diagramm, das vor einem Hintergrund aus Punkten exponentiell nach rechts oben zunimmt"
},
"en": {
"milkHeader": "Got Milk?",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only removed these for "en". Want me to jump in and remove for all localizations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an automated way to do this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I know of, or rather, I don't know of a way that's worth the effort of setting up given how infrequently we change this.

"milkSubheader": "$milkTIA now available on Osmosis",
"milkImageAlt": "milkTIA logo",
"tfmHeader": "Place limit orders",
"tfmSubheader": "Experience pro trading with TFM",
"tfmImageAlt": "Variable chart decreasing to the lower right, then increasing to the upper right with dollar signs",
"calcFiHeader": "Looking to DCA?",
"calcFiSubheader": "Set up recurring swaps with CalcFi",
"calcFiImageAlt": "Chart increasing to the upper right with dollar signs",
"marginedHeader": "Feeling bullish?",
"marginedSubheader": "Try quadratic leverage on Margined",
"marginedImageAlt": "Chart increasing exponentially to the upper right over a background of dots"
"calcFiImageAlt": "Chart increasing to the upper right with dollar signs"
},
"es": {
"milkHeader": "¿Tienes leche?",
Expand Down
Loading