remove margined and milkyway from banner #61
Conversation
| { | ||
| "name": "milkTIA", | ||
| "startDate": "2023-12-18T14:30:00.123Z", | ||
| "endDate": "2024-01-25T14:30:00.123Z", |
There was a problem hiding this comment.
Possibly we can make use of the endDate to hide this--in case might want to re-add this later. Or perhaps you prefer that it be removed completely when we aren't using it
There was a problem hiding this comment.
Oh yeah, let's use the end date feature then
There was a problem hiding this comment.
I cannot edit this PR, so if you aren't going to edit--I can make my own PR
There was a problem hiding this comment.
So MilkTIA ad is already hidden, so endDate does work, and for Margined I've set it to end yesterday, so it should hide.
I've made my own PR: #66
| @@ -74,18 +46,12 @@ | |||
| "marginedImageAlt": "Diagramm, das vor einem Hintergrund aus Punkten exponentiell nach rechts oben zunimmt" | |||
| }, | |||
| "en": { | |||
| "milkHeader": "Got Milk?", | |||
There was a problem hiding this comment.
This only removed these for "en". Want me to jump in and remove for all localizations?
There was a problem hiding this comment.
Is there an automated way to do this?
There was a problem hiding this comment.
Not that I know of, or rather, I don't know of a way that's worth the effort of setting up given how infrequently we change this.
No description provided.