Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of Kitchen-Terraform #42

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Deprecation of Kitchen-Terraform #42

merged 2 commits into from
Apr 27, 2024

Conversation

brettcurtis
Copy link
Contributor

Fixes #35

@brettcurtis brettcurtis self-assigned this Apr 27, 2024
Copy link

infracost bot commented Apr 27, 2024

💰 Infracost report

Monthly cost will not change

Changed project Baseline cost Usage cost* Total change New monthly cost
fixtures-default +$0 -$15 -$15 $0
tests-fixtures-default +$0 +$15 +$15 $15

*Usage costs were estimated using Infracost Cloud settings, see docs for other options.

Cost details
Key: * usage cost, ~ changed, + added, - removed

──────────────────────────────────
Project: fixtures-default
Module path: fixtures/default

- module.storage_bucket.google_storage_bucket.this
  -$15

    - Storage (standard)
      -$5, -192 GiB*

    - Object adds, bucket/object list (class A)
      -$5, -100 10k operations*

    - Object gets, retrieve bucket/object metadata (class B)
      -$5, -1,250 10k operations*

    - Network egress
    
        - Data transfer to worldwide excluding Asia, Australia (first 1TB)
          Monthly cost depends on usage
            -$0.12 per GB
    
        - Data transfer to Asia excluding China, but including Hong Kong (first 1TB)
          Monthly cost depends on usage
            -$0.12 per GB
    
        - Data transfer to China excluding Hong Kong (first 1TB)
          Monthly cost depends on usage
            -$0.23 per GB
    
        - Data transfer to Australia (first 1TB)
          Monthly cost depends on usage
            -$0.19 per GB

Monthly cost change for fixtures-default (Module path: fixtures/default)
Amount:  -$15 ($15 → $0.00)

──────────────────────────────────
Project: tests-fixtures-default
Module path: tests/fixtures/default

+ module.storage_bucket.google_storage_bucket.this
  +$15

    + Storage (standard)
      +$5, +192 GiB*

    + Object adds, bucket/object list (class A)
      +$5, +100 10k operations*

    + Object gets, retrieve bucket/object metadata (class B)
      +$5, +1,250 10k operations*

    + Network egress
    
        + Data transfer to worldwide excluding Asia, Australia (first 1TB)
          Monthly cost depends on usage
            +$0.12 per GB
    
        + Data transfer to Asia excluding China, but including Hong Kong (first 1TB)
          Monthly cost depends on usage
            +$0.12 per GB
    
        + Data transfer to China excluding Hong Kong (first 1TB)
          Monthly cost depends on usage
            +$0.23 per GB
    
        + Data transfer to Australia (first 1TB)
          Monthly cost depends on usage
            +$0.19 per GB

Monthly cost change for tests-fixtures-default (Module path: tests/fixtures/default)
Amount:  +$15 ($0.00 → $15)

──────────────────────────────────
Key: * usage cost, ~ changed, + added, - removed

*Usage costs were estimated using Infracost Cloud settings, see docs for other options.

1 cloud resource was detected:
∙ 1 was estimated

Governance checks

🟢 53 passed
52 FinOps policies and 1 Tagging policy passed.

View report in Infracost Cloud. This comment will be updated when code changes.

Copy link

coderabbitai bot commented Apr 27, 2024

Walkthrough

This update encompasses various modifications across multiple files, primarily focusing on updating testing frameworks and configurations. Key changes include transitioning from Kitchen-Terraform to a native test framework in Terraform, updating module paths, and upgrading dependency versions.

Changes

File(s) Change Summary
.github/workflows/test.yml Job renamed to "Tests"; updated repository source.
.pre-commit-config.yaml Updated pre-commit-terraform from v1.88.4 to v1.89.1.
README.md Updated Google provider version from 5.8.0 to 5.26.0.
empty.tf, tests/... Added new files for initializing Terraform and testing.
tests/fixtures/default/main.tf Updated module source path.

Assessment against linked issues

Objective Addressed Explanation
Tests re-written using native test framework [#35, #63, #20, #107, #36, #16, #17, #29, #18, #95]
Deprecation of Kitchen-Terraform addressed [#35, #63, #20, #107, #36, #16, #17, #29, #18, #95]

Possibly related issues

  • Issue #63: Deprecation of Kitchen-Terraform. The PR transitions to the native test framework, addressing the main objective.
  • Issue Align to standards #20: Similar to #63, focuses on transitioning away from Kitchen-Terraform due to its deprecation.
  • Issue #107: Again, addresses the need to migrate from Kitchen-Terraform to the native Terraform testing framework.
  • Issue #95: Discusses updates due to Kitchen-Terraform deprecation, which is directly addressed by the changes in this PR.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@brettcurtis brettcurtis merged commit 7ff912a into main Apr 27, 2024
3 checks passed
@brettcurtis brettcurtis deleted the brettcurtis/issue35 branch April 27, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Deprecation of Kitchen-Terraform
1 participant