Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds --push to mike depoly #1773

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: adds --push to mike depoly #1773

merged 1 commit into from
Dec 5, 2024

Conversation

jpower432
Copy link
Member

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Ensures changes are pushed to the gh-pages branch

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@jpower432
fix: adds --push to mike deploy
c89a449 
Ensures changes are pushed to the gh-pages branch

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 requested a review from a team as a code owner December 5, 2024 13:27
@jpower432 jpower432 requested a review from butler54 December 5, 2024 13:27
@jpower432 jpower432 added this to the v3.6.0 milestone Dec 5, 2024
@jpower432
Copy link
Member Author

Related to #1769

butler54
butler54 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit c70c145 into users Dec 5, 2024
11 checks passed
@jpower432 jpower432 deleted the bug/mike-deploy-push branch December 5, 2024 13:51
jpower432 added a commit that referenced this pull request Dec 5, 2024
@butler54 @jpower432
fix: set user id for doco pipeline (#1769)
6f51549 
* fix: set user id for doco pipeline

Signed-off-by: Chris Butler <chris.butler@redhat.com>

* fix: adds --push to mike deploy (#1773)

Ensures changes are pushed to the gh-pages branch

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

---------

Signed-off-by: Chris Butler <chris.butler@redhat.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Co-authored-by: Jennifer Power <barnabei.jennifer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butler54 butler54 butler54 approved these changes

@vikas-agarwal76 vikas-agarwal76 Awaiting requested review from vikas-agarwal76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @butler54