Insights Compliance integration (HMS-3829)

[croissanne]

The current state:

compliance-radio-.2.mp4

One thing worth discussing is how we want to expose the compliance step. Should we show it alongside the existing openscap step? Should the steps be merged?

Since it would only be in preview, how about we just show both steps for now, knowing that they might conflict?

[codecov]

Codecov Report

Attention: Patch coverage is 94.30605% with 32 lines in your changes missing coverage. Please review.

Project coverage is 83.88%. Comparing base (1a7350e) to head (aca2bd3).
Report is 2177 commits behind head on main.

Files with missing lines	Patch %	Lines
...Components/CreateImageWizard/steps/Oscap/Oscap.tsx	91.48%	16 Missing ⚠️
api/config/compliance.ts	0.00%	12 Missing and 1 partial ⚠️
...Components/CreateImageWizard/steps/Oscap/index.tsx	97.89%	2 Missing ⚠️
src/test/mocks/handlers.js	92.30%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main    #2440      +/-   ##
==========================================
+ Coverage   75.71%   83.88%   +8.17%     
==========================================
  Files          33      157     +124     
  Lines         597    17694   +17097     
  Branches      144     1747    +1603     
==========================================
+ Hits          452    14843   +14391     
- Misses        139     2830    +2691     
- Partials        6       21      +15     

Files with missing lines	Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx	99.41% <100.00%> (ø)
...ageWizard/steps/FileSystem/FileSystemPartition.tsx	95.45% <100.00%> (ø)
...mageWizard/steps/Oscap/OscapProfileInformation.tsx	100.00% <100.00%> (ø)
...ents/CreateImageWizard/steps/Review/ReviewStep.tsx	92.94% <100.00%> (ø)
...teImageWizard/steps/Review/ReviewStepTextLists.tsx	93.91% <100.00%> (ø)
...nents/CreateImageWizard/utilities/requestMapper.ts	94.85% <100.00%> (ø)
src/constants.ts	100.00% <100.00%> (ø)
src/store/complianceApi.ts	100.00% <100.00%> (ø)
src/store/emptyComplianceApi.ts	100.00% <100.00%> (ø)
src/store/imageBuilderApi.ts	86.51% <ø> (ø)
... and 9 more

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a796630...aca2bd3. Read the comment docs.

[ochosi]

We could show the OpenSCAP step as fallback, if a customer hasn't set up any policy yet.

And then we could show a huge throbbing notice that they can easily create a policy if they want tailoring?

[regexowl]

This looks awesome so far! Added a few comments that should help with the noise in test outputs.

"radio buttoning" between compliance and Oscap will be great in eliminating the overlap

[regexowl]

Looks great with the radio! Added a few nitpicks.

[croissanne]

/retest

[croissanne]

/retest

[regexowl]

failed on teardown with "wait_for.TimedOutError: Could not do 'lambda defined as `ret, _ = wait_for(lambda: self.is_displayed, timeout=timeout, delay=delay)`' at /iqe_venv/lib/python3.11/site-packages/widgetastic/widget/base.py:533 in time"

is currently an expected failure. @jrusz is looking into it. Since the PR failed on the final cleanup, pr_check shouldn't need any adjustment.

[regexowl]

Thank you! Looks and works great ✨

[jrusz]

/retest