Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public access for fd proto builder #16

Open
jhsenjaliya opened this issue Jun 2, 2020 · 3 comments
Open

public access for fd proto builder #16

jhsenjaliya opened this issue Jun 2, 2020 · 3 comments

Comments

@jhsenjaliya
Copy link
Contributor

both mFileDescSetBuilder and mFileDescSetBuilder is useful to be accessible too make use of it in other methods. I already have use for mFileDescProtoBuilder.
would it be possible to make it public ?
@jhsenjaliya
Copy link
Contributor Author

or if we can make the constructor public, user can also create the DynamicSchema using FileDescriptor directly.
@os72 pls let me know ur thoughts.
THanks

@jhsenjaliya
Copy link
Contributor Author

@os72 , did u get chance to look at this? I can plan to open PR for this.

@os72
Copy link
Owner

os72 commented Aug 15, 2020 •
edited
Loading

Hi @jhsenjaliya yes thanks please feel free to create a PR
Please note I need to limit the time I dedicate to this project. Finding some sponsorship would help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhsenjaliya @os72