fix: test

ory · Feb 3, 2025 · 2c6e7a1 · 2c6e7a1
1 parent d29f93a
commit 2c6e7a1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/consent/strategy_default.go b/consent/strategy_default.go
@@ -585,13 +585,13 @@ func (s *DefaultStrategy) forwardConsentRequest(
 
 	// Set up csrf/challenge/verifier values
 	verifier := strings.Replace(uuid.New(), "-", "", -1)
-	challenge := strings.Replace(uuid.New(), "-", "", -1)
+	consentChallengeID := strings.Replace(uuid.New(), "-", "", -1)
 	csrf := strings.Replace(uuid.New(), "-", "", -1)
 
 	cl := sanitizeClientFromRequest(ar)
 
 	consentRequest := &flow.OAuth2ConsentRequest{
-		ID:                     challenge,
+		ID:                     consentChallengeID,
 		ACR:                    as.ACR,
 		AMR:                    as.AMR,
 		Verifier:               verifier,

diff --git a/consent/test/manager_test_helpers.go b/consent/test/manager_test_helpers.go
@@ -535,7 +535,7 @@ func ManagerTests(deps Deps, m consent.Manager, clientManager client.Manager, fo
 					require.Error(t, err)
 
 					consentChallenge = x.Must(f.ToConsentChallenge(ctx, deps))
-					consentRequest.ID = consentChallenge
+					// consentRequest.ID = consentChallenge
 
 					err = m.CreateConsentRequest(ctx, f, consentRequest)
 					require.NoError(t, err)
@@ -1076,7 +1076,7 @@ func ManagerTests(deps Deps, m consent.Manager, clientManager client.Manager, fo
 			f, err := m.CreateLoginRequest(ctx, lr)
 			require.NoError(t, err)
 			expected := &flow.OAuth2ConsentRequest{
-				ID:                   x.Must(f.ToConsentChallenge(ctx, deps)),
+				ID:                   uuid.NewString(),
 				Skip:                 true,
 				Subject:              subject,
 				OpenIDConnectContext: nil,
@@ -1091,14 +1091,17 @@ func ManagerTests(deps Deps, m consent.Manager, clientManager client.Manager, fo
 			err = m.CreateConsentRequest(ctx, f, expected)
 			require.NoError(t, err)
 
-			result, err := m.GetConsentRequest(ctx, expected.ID)
+			consentChallenge, err := f.ToConsentChallenge(ctx, deps)
+			require.NoError(t, err)
+
+			result, err := m.GetConsentRequest(ctx, consentChallenge)
 			require.NoError(t, err)
 			assert.EqualValues(t, expected.ID, result.ID)
 
 			_, err = m.DeleteLoginSession(ctx, s.ID)
 			require.NoError(t, err)
 
-			result, err = m.GetConsentRequest(ctx, expected.ID)
+			result, err = m.GetConsentRequest(ctx, consentChallenge)
 			require.NoError(t, err)
 			assert.EqualValues(t, expected.ID, result.ID)
 		})