-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing Mods (4) #10
Comments
About the Comments, I had suggested what I've seen on the Forum Topic itself. And combine them with that or a better kind of order Screenshots and Gifs are very useful. |
The other thing is, put mod settings above the meta header. |
I think mods should also have the “mod” tag to distinguish them from questions posted to the mod forum. |
Mod Settings? Yes, |
While ideally mod settings would be put in vivaldi://settings, they are often put in code. That code could be at the very top, then the informational header, then the main code. |
I’d swap these two. |
I will do this one as well. |
@tiosgz Why? Because it makes more sense? Because that's the way we've always done it? Because it's hard to convince people to change too many things at once? Not trying to be picky, just asking. |
Because those comments are always at the very beginning, mostly due to parsing, but here also because it provides an easy way for people to split mods dumped into one file. |
Should this be closed now that a corresponding pull request is opened? |
Whoops, wrong issue |
Nope. But you should add something like
to the PR’s OP so that it is automatically closed once the PR is merged. (Thinking of it, you don’t have to. But it’s a good practice.)
Wrong issue? #11 |
What comment should be used at the top of mod files?
What tags should be used in forum posts?
Should we ask people to include screenshots or anything else?
What tools are good for making an animated GIF?
The text was updated successfully, but these errors were encountered: