Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing Mods (4) #10

Open
code3z opened this issue May 19, 2021 · 12 comments · May be fixed by #15
Open

Sharing Mods (4) #10

code3z opened this issue May 19, 2021 · 12 comments · May be fixed by #15
Labels
misc About modding, but not modding itself

Comments

@code3z
Copy link
Contributor

code3z commented May 19, 2021

What comment should be used at the top of mod files?
What tags should be used in forum posts?
Should we ask people to include screenshots or anything else?

What tools are good for making an animated GIF?

@Zalext
Copy link

Zalext commented May 19, 2021

About the Comments, I had suggested what I've seen on the Forum Topic itself.
For Tags, Luetage said on the Topic: Type:: CSS/Js - Element:: Panel/TabBar/BookmarksBar/... BackUp:: Themes/BKs/SearchEngines...

And combine them with that or a better kind of order

Screenshots and Gifs are very useful.
For Gifs, on Win LiceCap works fine.

@code3z
Copy link
Contributor Author

code3z commented May 20, 2021

The other thing is, put mod settings above the meta header.

@code3z
Copy link
Contributor Author

code3z commented May 20, 2021

I think mods should also have the “mod” tag to distinguish them from questions posted to the mod forum.

@ghost ghost added the basics Concerns basic modding skills label May 20, 2021
@Zalext
Copy link

Zalext commented May 20, 2021

Mod Settings?

Yes,
To add Mod as Tag was said also.

@code3z
Copy link
Contributor Author

code3z commented May 20, 2021

While ideally mod settings would be put in vivaldi://settings, they are often put in code. That code could be at the very top, then the informational header, then the main code.

@ghost
Copy link

ghost commented May 20, 2021

That code could be at the very top, then the informational header

I’d swap these two.

@code3z
Copy link
Contributor Author

code3z commented May 24, 2021

I will do this one as well.

@code3z
Copy link
Contributor Author

code3z commented May 24, 2021

That code could be at the very top, then the informational header

I’d swap these two.

@tiosgz Why? Because it makes more sense? Because that's the way we've always done it? Because it's hard to convince people to change too many things at once?

Not trying to be picky, just asking.

@ghost
Copy link

ghost commented May 25, 2021

Because those comments are always at the very beginning, mostly due to parsing, but here also because it provides an easy way for people to split mods dumped into one file.

@code3z
Copy link
Contributor Author

code3z commented May 26, 2021

Should this be closed now that a corresponding pull request is opened?

@code3z
Copy link
Contributor Author

code3z commented May 26, 2021

Whoops, wrong issue

@ghost
Copy link

ghost commented May 26, 2021

Should this be closed now that a corresponding pull request is opened

Nope. But you should add something like

Fixes #10

to the PR’s OP so that it is automatically closed once the PR is merged. (Thinking of it, you don’t have to. But it’s a good practice.)

https://docsify.js.org/#/

I could set this up once we have 6 or so pages

Wrong issue? #11

@ghost ghost linked a pull request May 29, 2021 that will close this issue
@ghost ghost added misc About modding, but not modding itself and removed basics Concerns basic modding skills labels May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc About modding, but not modding itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants