test weirdness

[tessus]

I was trying to look into the test test_upload_duplicate_file that fails with tarpaulin. Turns out this test also fails with nextest.

It is the only test that creates an upload dir fs::create_dir(test_upload_dir)?;

When I tried to use the current dir (as all other tests do), this test stalls and runs for about 90 seconds - and passes (in nextest, I haven't tried tarpaulin).

It hangs for 40s at both instances of test::call_service(....).

With the upload dir set to something, it doesn't stall but the test fails. I am very puzzled by this. @orhun are you aware of any side effects of actix_web::test::test_utils?

[orhun]

That's really weird. I'm not aware of any issues with test_utils but maybe it is an concurrency issue? Something might be locking?

[tessus]

also, it seems we have issues again with the #246 PR.

[orhun]

oops, I missed that, just watched the issue.

also, it seems we have issues again with the #246 PR.

god damn it!

I will take a look soon :D

[tessus]

this time another test fails. What worries me is that codecov and nextest might point out that there is actually an issue with the test, but we haven't noticed it.
But I checked the tests and they seem perfectly fine from a test perspective: process, reason, test case, result. Unless I am missing something.

[tessus]

@orhun, I've got an answer from the tarpulin dev that could help:

xd009642/tarpaulin#1488 (comment)

[orhun]

@tessus thanks for tracking this!

Should we give it a shot for reverting to cargo-tarpaulin in CI and using the suggested flags then?