IIS Extension: CacheControlMaxAge, error on value which produces msi NULL column value

[bevanweiss]

I've been working up some test cases for the IIS Extension, as I look to deal with a few of the backlog issues.

One issue that I've come across with the existing codebase.
The CacheControlMaxAge is configured as a 32bit unsigned value in the C# frontend, and the C++ backend... however inbetween it needs to pass through the MSI database. This results in the possibility that an author puts in an unsigned '2147483648' (0x80000000) value for this attribute, which then results in the MSI column holding a NULL value.

An example as below which ends up failing because of the NULL.

<iis:WebSite Id="Test" Description="Test web server" Directory="TestWebSiteProductDirectory" AutoStart="yes" ConfigureIfExists="no" >
  <iis:WebDir Id="TestDirCacheControlMaxAgeNull" Path="TestCacheControlMaxAgeNull">
    <iis:WebDirProperties Id="TestCacheControlMaxAgeNull" CacheControlMaxAge="2147483648" />
  </iis:WebDir>
</iis:WebSite>

My thoughts are:

1. Add a WiX validation that ensures this value isn't entered into the attribute at authoring time, and generates an error if it is.
2. Silently increment/decrement this value such that it's not the MSI_NULL_INTEGER value.

My thought is that the first option is the right one, but with the annoyance that it might break some currently 'invalid' authoring out in the wild.
Any opinions around this one? (is there another option that I'm missing?)

[robmen]

I agree. Option 1.