feat: retain debug tracing behavior of default logger #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tauu It would be great if you can fix the test to get this moving. |
|
done. :-) I modified the PR a bit to store the log level set via LogMode() instead of altering the traceAll flag. |
|
@orandin This looks more like a bug to me than an enhancement. Without this change, the implementation is not fulfilling the interface intention. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 129 138 +9
=========================================
+ Hits 129 138 +9 ☔ View full report in Codecov by Sentry. |
|
@tauu Thank you for your contribution 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the same debug handling, which the default gorm logger uses. That is calling
db.Debug()with db being a*gorm.DBobject, will enable logging of all database queries for the returnedgorm.DB. This functionality is commonly used to debug specific queries in a program.\db.Debug()sets the log level of the default logger to "info" to achieve this behavior. Retaining this functionality is implemented by setting the traceAll flag to true, when the log level is set to info via the LogMode interface function.