Remove java.io.Serializable #389
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Craigacp
force-pushed
the
no-serialization
branch
from
334e81c to
d1c3eac
Compare
| throw new IllegalArgumentException("Unknown class in serialised model", e); | ||
| } | ||
| } | ||
| Model<?> tmpModel = Model.deserializeFromFile(modelPath); | ||
| Model<Label> model = tmpModel.castModel(Label.class); | ||
| logger.info(String.format("Loading data from %s", datasetPath)); | ||
| Dataset<Label> test; | ||
| switch (o.inputFormat) { | ||
| case SERIALIZED: |
There was a problem hiding this comment.
Isn't this kind of a breaking change? Code that previously expected java serialization would not inadvertently be using a proto serialization path.
| /** | ||
| * Load in the model in protobuf format. | ||
| */ | ||
| @Option(longName = "protobuf-model", usage = "Load the model from a protobuf. Optional") |
There was a problem hiding this comment.
Again isn't this a breaking change? Code that was using this arg will now crash, even though it was doing things the 'right' way
| @@ -217,30 +210,6 @@ public <T extends Output<T>> Pair<Dataset<T>,Dataset<T>> load(OutputFactory<T> o | |||
| char separator; | |||
| switch (inputFormat) { | |||
| case SERIALIZED: | |||
There was a problem hiding this comment.
Another breaking change, as above
| /** | ||
| * Is the model stored in protobuf format? | ||
| */ | ||
| @Option(longName="model-protobuf",usage="Is the model stored in protobuf format?") |
There was a problem hiding this comment.
Another breaking change as the option one above
| /** | ||
| * Is the serialized dataset in protobuf format? | ||
| */ | ||
| @Option(longName="dataset-protobuf",usage="Is the serialized dataset a protobuf?") |
| /** | ||
| * Read and write protobuf formatted models. | ||
| */ | ||
| @Option(longName = "model-protobuf", usage = "Read and write protobuf formatted models.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes support for java.io.Serializable from all main Tribuo types. The only supported serialization mechanism is protobuf. Fixes #391.
Motivation
java.io.Serializable makes it difficult to migrate classes.