Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): skip comparing Macaron version in VSA test #607

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

behnazh-w
Copy link
Member

This PR fixes an issue in the VSA comparison integration test. We should not compare Macaron version against the snapshot test VSA because the test will fail once we bump the Macaron version in the next release, failing the automatic release altogether!

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w requested a review from benmss January 18, 2024 01:15
@behnazh-w behnazh-w requested a review from tromai as a code owner January 18, 2024 01:15
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 18, 2024
@behnazh-w behnazh-w removed the request for review from tromai January 18, 2024 01:15
@behnazh-w behnazh-w merged commit ea07203 into staging Jan 18, 2024
9 checks passed
@nathanwn nathanwn deleted the behnazh/fix-vsa-integration-test branch February 13, 2024 03:07
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
This PR fixes an issue in the VSA comparison integration test. We should not compare Macaron version against the snapshot test VSA because the test will fail once we bump the Macaron version in the next release, failing the automatic release altogether!

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants