test: fix the GitHub Actions workflow detection test #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
nathanwn
reviewed
Jan 5, 2024
|
I think most test functions in the file are quite repetitive, repeating the same test logic for a few cases within the same test function, and could be refactored into table-driven tests with |
|
See commit 9e4bfc9 |
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
behnazh-w
force-pushed
the
bh/fix-ghaction-test
branch
from
416179a to
9e4bfc9
Compare
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
This PR fixes a bug in the GitHub Actions workflow detection test. The assertions in the test_get_workflows function were checking the return values of list.sort(), which is an in-place function and doesn't return anything. Instead we should compare the sorted lists. This PR also refactors the tests and removes MacaronTestCase, which is not necessary anymore. Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the GitHub Actions workflow detection test. The assertions in the
test_get_workflowsfunction were checking the return values oflist.sort(), which is an in-place function and doesn't return anything. Instead we should compare the sorted lists.This PR also removes
MacaronTestCase, which is not necessary anymore.