Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(test): fix the test descriptions and comparison for micronaut-test #579

Conversation

behnazh-w
Copy link
Member

Closes #577

This PR fixes the description of test for micronaut-test and also removes the test that uses PURL pkg:maven/io.micronaut/micronaut-test-core@4.1.0 because for some reason this artifact is not published on Maven central. This test should have been failing but we were checking the wrong output file.

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w requested a review from tromai as a code owner December 22, 2023 03:03
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 22, 2023
@nathanwn nathanwn changed the title ci(test): fix the test desciptions and comarison for micronaut-test ci(test): fix the test descriptions and comparison for micronaut-test Dec 22, 2023
Copy link
Member

@tromai tromai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. LTGM

@behnazh-w behnazh-w merged commit 3ac07ba into staging Dec 22, 2023
12 checks passed
@behnazh-w behnazh-w deleted the 577-one-micronaut-test-integration-test-is-running-with-a-purl-but-we-check-for-dependency-report-files branch January 5, 2024 05:42
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
…#579)

This PR fixes the description of test for `micronaut-test` and also removes the test that uses PURL `pkg:maven/io.micronaut/micronaut-test-core@4.1.0` because for some reason this artifact is not published on Maven central. This test should have been failing but we were checking the wrong output file.

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants